Re: [PATCH] Should (buffer-list) ever return killed buffers?

[Sergey Organov]

Philipp <p.stephani2@gmail.com> writes:

>> Am 24.05.2021 um 17:32 schrieb Sergey Organov <sorganov@gmail.com>:
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>>>> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
>>>> From: martin rudalics <rudalics@gmx.at>
>>>> Date: Mon, 24 May 2021 16:50:48 +0200
>>>> 
>>>>>> +        (unless (or (nill bufname)
>>>>>> +                    (eq (aref bufname 0) ?\s) ;; Don't kill internal 
>>>>>> buffers
>>>>>>                      (string-match-p preserve-regexp bufname))
>>>>>>            (kill-buffer buffer)))))
>>>>>>    (delete-other-windows)
>>>>> 
>>>>> AFAICT, kill-buffer already is a no-op when the buffer is dead.  So
>>>>> what exactly does this fix?  (Apologies if I'm missing something: I
>>>>> cannot say that I've read all the discussions in this thread to the
>>>>> last detail.)
>>>> 
>>>> Sergey never told us but it's likely `aref' choking on nil.
>>> 
>>> Then why not use buffer-live-p?
>> 
>> Cause aref is choking on bufname being nil, I think. What if
>> representation of killed buffers change?
>
> That won't happen. The ELisp manual guarantees that "[t]he
> ‘buffer-name’ of a buffer is ‘nil’ if, and only if, the buffer is
> killed."

Probably. I provided a patch as convenience. Whatever fix you guys
come-up with, I'll be happy to use.

Thanks,
-- Sergey Organov