Re: fido-vertical bindings

[Ergus]

Just a question:

Why icomplete-scroll is not a custom? It is not intended to be set by
the user?

On Wed, Aug 18, 2021 at 02:25:58PM +0200, Ergus wrote:
> Perfect!!
>
> Very thanks Joao.
>
> On Tue, Aug 17, 2021 at 01:08:37PM +0100, Jo�o T�vora wrote:
> > Ergus <spacibba@aol.com> writes:
> >
> > > I just tried the new fido-vertical you added.
> >
> > I added it some time ago, IIRC.  What I've done very recently is make it
> > enable fido-mode automatically, so that you don't need two foo-mode
> > calls to get the desired functionality.  So
> >
> > M-x fido-vertical-mode
> >
> > is all you need.
> >
> > > I think there is a small issue very simple to fix. In vertical mode
> > > either the right/left arrows and C-n/p may be switched with the actual
> > > up/down and maybe C-r C-s... to have a consistent behavior.
> >
> > I had a tough time understanding what you meant, but now I think I do
> > and I just committed the patch after my sig.
> >
> > If you use fido-vertical-mode, also notice the new goto-first/last stuff
> > suggested by Simon Lang in bug#49005.
> >
> > Jo�o
> >
> > diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> > index 96b7e0f201..81fc6ff03c 100644
> > --- a/lisp/icomplete.el
> > +++ b/lisp/icomplete.el
> > @@ -624,6 +624,8 @@ icomplete-vertical-mode-minibuffer-map
> >  (let ((map (make-sparse-keymap)))
> >    (define-key map (kbd "C-n") 'icomplete-forward-completions)
> >    (define-key map (kbd "C-p") 'icomplete-backward-completions)
> > +    (define-key map (kbd "<down>") 'icomplete-forward-completions)
> > +    (define-key map (kbd "<up>") 'icomplete-backward-completions)
> >    (define-key map (kbd "M-<") 'icomplete-vertical-goto-first)
> >    (define-key map (kbd "M->") 'icomplete-vertical-goto-last)
> >    map)