[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] memory-report: support calculating size for structures
From: |
Lars Ingebrigtsen |
Subject: |
Re: [PATCH] memory-report: support calculating size for structures |
Date: |
Sun, 29 Aug 2021 21:11:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Yikai Zhao" <yikai@z1k.dev> writes:
> Here's another patch on memory-report package which fixes the object
> size calculation for structures (cl-defstruct types). Before this
> patch, memory-report--object-size will report empty size for structure
> objects, which results in incorrect report about "Largest Variables"
> in memory-report result.
Thanks; looks good.
> Regarding the copyright assignment, I'm currently in the progress of
> signing it. But maybe this patch is small enough to apply without it?
In itself, it would be small enough, but with the previous patch, it
pushes it above the limit. So after the assignment process is complete,
can you remind us to apply the patch. (And perhaps put the patch into
the issue tracker with `M-x submit-emacs-patch' so that it's not
forgotten.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no