[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Native compiler - passing command line options to C compiler
From: |
Andrea Corallo |
Subject: |
Re: Native compiler - passing command line options to C compiler |
Date: |
Mon, 30 Aug 2021 09:36:09 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Arthur Miller <arthur.miller@live.com> writes:
> Hi again,
>
> after the few mails the other day, I wasn't really sure if Andrea is going to
> implement it and when.
Sure I was going to implent it as I said so, but thanks for taking the
task :)
> I thought it was rather a tedious manual labour and maybe
> not so important, so I took me a liberty to implement this myself in my own,
> so
> called, personal copy of Eamcs sources.
>
> I am not sure if I have done it correctly though, I appreciate if Andrea have
> time to take a look;
I just have a small suggestion.
> Mark set
>
> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> index 80a1da5ad8..58d361cf46 100644
> --- a/lisp/emacs-lisp/comp.el
> +++ b/lisp/emacs-lisp/comp.el
> @@ -166,6 +166,16 @@ native-comp-async-query-on-exit
> :type 'boolean
> :version "28.1")
>
> +(defcustom native-comp-compiler-options nil
> + "Options passed verbatim to the native compiler's c driver.
I'd just say "passed to the compiler" or "passed to GCC" as there's no C
involed.
> +#endif
> + if (CONSP (options))
> + xsignal1 (Qnative_compiler_error,
> + build_string ("Customizing native compiler options"
> + " via `comp-native-compiler-options' is"
> + " only available on libgccjit version 9"
> + " and above."));
> +
> + /* Captured `comp-native-driver-options' because file-local. */
^^^
native-comp-compiler-options ?
Other that that the patch LGTM. Could you provide it with its
Changelog?
TIA
Andrea
- Native compiler - passing command line options to C compiler, Arthur Miller, 2021/08/29
- Re: Native compiler - passing command line options to C compiler,
Andrea Corallo <=
- Re: Native compiler - passing command line options to C compiler, Eli Zaretskii, 2021/08/30
- Re: Native compiler - passing command line options to C compiler, Andrea Corallo, 2021/08/30
- Re: Native compiler - passing command line options to C compiler, Eli Zaretskii, 2021/08/30
- Re: Native compiler - passing command line options to C compiler, Andrea Corallo, 2021/08/30
- Re: Native compiler - passing command line options to C compiler, Arthur Miller, 2021/08/30
- Re: Native compiler - passing command line options to C compiler, Andrea Corallo, 2021/08/30
- Re: Native compiler - passing command line options to C compiler, Arthur Miller, 2021/08/31
- Re: Native compiler - passing command line options to C compiler, Andrea Corallo, 2021/08/31