emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gitlab Migration


From: Dmitry Gutov
Subject: Re: Gitlab Migration
Date: Mon, 30 Aug 2021 15:32:40 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 30.08.2021 09:31, Drew DeVault wrote:
On Mon Aug 30, 2021 at 12:27 AM CEST, Dmitry Gutov wrote:
When you say it's not a requirement, how does the alternative work?

Suppose I have a feature branch scratch/exciting-new-feature.

And it has a number of existing commits A, B, C, where I did some work
on said feature.

Then I do a merge from master, creating a merge commit M which resolves
a conflict. It also pulls commits M1 and M2 from master into the branch,
both of which have a later creation date than A.

Then I add commits D and E with some subsequent work.

Honestly, by doing this you have created a poor git history which I, as
a maintainer, would not care to review, be it via email or any other
means including the GitHub workflow. I would teach you how to rebase it
properly instead of accepting this work, and I think that emacs would be
wise to do the same.

So far it has been common practice around these parts, but OK.

However, you can still work with this on sourcehut by using git
request-pull(1):

https://www.git-scm.com/docs/git-request-pull

There is no UI for this, but it is planned.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]