emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 2ed2999: Improve documentation of new Xref options


From: Eli Zaretskii
Subject: Re: master 2ed2999: Improve documentation of new Xref options
Date: Tue, 07 Sep 2021 16:05:47 +0300

> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 6 Sep 2021 18:43:55 +0300
> 
> On 06.09.2021 18:33, Eli Zaretskii wrote:
> 
> >>> and xref-find-references?
> >>
> >> Also xref-find-apropos, project-find-regexp, dired-do-find-regexp and
> >> any other third-party or future callers of xref-show-xrefs-function will
> >> be affected by xref-auto-jump-to-first-xref.
> > 
> > So basically xref-auto-jump-to-first-xref affects any command that is
> > expected to display many matches, would that be a correct summary?
> 
> Could be.
> 
> Or "commands which display many matches, with high likelihood that the 
> user will want to visit every match, rather than just pick one". At 
> least that was the thinking behind xref-show-definitions-function vs 
> xref-show-xrefs-function.

OK, I hope I fixed this stuff now, please take a look.

> >>> And what about stuff like
> >>> dired-do-find-regexp-and-replace -- is that affected by any of these?
> >>
> >> dired-do-find-regexp-and-replace is affected as well right now, but
> >> that's a bug to be fixed (thanks for bringing it up).
> > 
> > I see you fixed that already, but what about dired-do-find-regexp?
> 
> It's in the same category as xref-find-references and others. Should 
> work fine already.

Should we perhaps treat dired-do-find-regexp like we do with
dired-do-find-regexp-and-replace, to avoid confusion due to
inconsistency?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]