Re: [Patch] Draw and scribble notes in GNU Emacs

[Lars Ingebrigtsen]

Anand Tamariya <atamariya@gmail.com> writes:

> Existing code doesn't ensure ids are unique.

svg--append isn't the function to ensure this.  It's a very confusing
interface if a function like svg--append would make other nodes suddenly
disappear.

(And besides, `dom-remove-node' is very slow, so it shouldn't be used in
a function like this.)

> Furthermore, in case id is duplicated, only the attributes on the
> first tag gets replaced. That's a little unpredictable behaviour from
> an API perspective.

It's unpredictable, but the new version is still unpredictable -- but in
a different way, so I don't see a net positive here.  We're altering the
behaviour from one slightly odd interface to another slightly odd
interface.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no