Re: master 788a658: Do not save empty passwords in auth-source-search

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>> branch: master
>> commit 788a65862ed9b9bc0437a016cae7e3ba1282a1a7
>> Author: Michael Albinus <michael.albinus@gmx.de>
>> Commit: Michael Albinus <michael.albinus@gmx.de>
>>
>>     Do not save empty passwords in auth-source-search
>
> This apparently leads to:
>
> Test auth-source-test-netrc-create-secret condition:
>     (ert-test-failed
>      ((should
>        (string-equal
>       (plist-get auth-info :user)
>       (user-login-name)))
>       :form
>       (string-equal nil "larsi")
>       :value nil))
>    FAILED  18/23  auth-source-test-netrc-create-secret (0.009026 sec)
>    passed  19/23  auth-source-test-netrc-parse-entry (0.000077 sec)
>    passed  20/23  auth-source-test-netrc-parse-one (0.000046 sec)
>    passed  21/23  auth-source-test-remembrances-of-things-past (0.000052 sec)
>    passed  22/23  auth-source-test-searches (0.001280 sec)
> Saved new authentication information to session
>    passed  23/23  auth-source-test-secrets-create-secret (0.055276 sec)
>
> Ran 23 tests, 22 results as expected, 1 unexpected (2021-09-20 07:02:39+0200, 
> 0.211667 sec)
>
> 1 unexpected results:
>    FAILED  auth-source-test-netrc-create-secret
>
> (But I haven't verified that it's this commit that's the cause.)

Likely yes, because that commit has added the test.

Strange, as you would expect this runs for me w/o problems. Hmm, there is
a wrong skip-unless, which prevents it to run on emba. I'll fix this, in
order to see whether it runs there, as first analysis step.

Best regards, Michael.