emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tab-line: New tab-line-tab-face-modified face


From: Juri Linkov
Subject: Re: [PATCH] tab-line: New tab-line-tab-face-modified face
Date: Sat, 25 Sep 2021 22:18:52 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

>> But why font-lock-doc-face?  Have you tried to change tab background color?
>> I guess this would be more visually pleasing.  Or maybe not.  This needs
>> more experimentation.
>
> Because in the default theme, it results in text that's a dark red,
> which is easily distinguished against the default tab background color,
> while still being readable (IMHO).  It reminds me of other editors I've
> used that use the red color to indicate a modified tab, so I think it
> should be somewhat familiar to users.  And by using a "font-lock-" face,
> it will be themed automatically by common third-party themes; while that
> doesn't guarantee it will look good with any theme by default, it should
> help.

Ah, this explains everything - a dark red makes sense, but long ago
I customized this face to green and forgot that by default it's dark red :)

Thanks for the patch, now applied.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]