Re: master 2c79a8f 2/2: Use posix_spawn if possible.

[Philipp Stephani]

Am Mi., 3. Nov. 2021 um 04:24 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > Date: Tue, 2 Nov 2021 20:36:04 +0000
> > From: Alan Third <alan@idiocy.org>
> > Cc: p.stephani2@gmail.com, mituharu@math.s.chiba-u.ac.jp,
> >       emacs-devel@gnu.org
> >
> > > > Is there anything we need to do to get scratch/posix-spawn-no-gnulib
> > > > merged into master (or even emacs-28)?
> > >
> > > Does it solve the problem?  And which builds does it affect?
> >
> > As I understand it Yamamoto Mitsuharu has already merged it into the
> > Mac port and I've seen it reported that the problems are solved with
> > it.
> >
> > I don't have a Mac with the latest macOS on to test it myself.
> >
> > This is really only a problem on macOS, so we could limit the use of
> > posix_spawn to Darwin builds.
> >
> > I am concerned that there could be hidden issues with the branch since
> > it doesn't seem to have had much testing, so it's probably best going
> > into master, but I expect we'll see an increasing number of complaints
> > about performance as more people switch to macOS 12. Perhaps we should
> > keep it in mind as a possible update for 28.2, whenever that may be.
>
> It is fine with me to merge this to master, as a macOS-only feature,
> unless Philipp has reasons not to do that yet.  We can reconsider
> backporting to emacs-28 at a later date, if and when we get enough
> complaints.

Is there a specific reason why we'd want to restrict this to macOS on
master? If the concern is lack of test coverage, then using the branch
on as many OSes as possible would help address that.