Re:Re: [PATCH] xwidget: Add xwidget-webkit-buffer-name-format (Re:Re: About rename xwidget-webkit-buffer-name-prefix)

[tumashu]

--
发自我的网易邮箱手机智能版

<br/><br/><br/>


----- Original Message -----
From: "Eli Zaretskii" <eliz@gnu.org>
To: tumashu <tumashu@163.com>
Cc: luangruo@yahoo.com, emacs-devel@gnu.org
Sent: Wed, 10 Nov 2021 15:54:21 +0200
Subject: Re: [PATCH] xwidget: Add xwidget-webkit-buffer-name-format (Re:Re: About rename xwidget-webkit-buffer-name-prefix)

> Date: Wed, 10 Nov 2021 17:49:04 +0800 (CST)
> From: tumashu  <tumashu@163.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> -*** New user option 'xwidget-webkit-buffer-name-prefix'.
> +*** New user option 'xwidget-webkit-buffer-name-format'.
>  This allows the user to change the webkit buffer names.

  Using this option you can control how the xwidget-webkit buffers are
  named.

> +(defcustom xwidget-webkit-buffer-name-format "*xwidget-webkit: %T*"
> +  "Buffer name format used by `xwidget-webkit' buffers.

    Template for naming `xwidget-webkit' buffers.
  It can use the following special constructs:

    %T -- the title of the Web page loaded by the xwidget.

> +                 (rename-buffer
> +                  (format-spec
> +                   xwidget-webkit-buffer-name-format
> +                   `((?T . ,title)))
> +                  t)))))

Hmmm... does this mean that the format spec _must_ contain %T?
Because otherwise all the buffers will have the same name, no?
Which would mean this change introduces a regression wrt how this

worked previously, right?

we use (rename-buffer xxx t), so i think buffer name will different but similar when no %T,