emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New function for explictly killing xwidgets


From: Eli Zaretskii
Subject: Re: New function for explictly killing xwidgets
Date: Sun, 14 Nov 2021 09:13:48 +0200

> From: Po Lu <luangruo@yahoo.com>
> Date: Sun, 14 Nov 2021 13:04:54 +0800
> 
> * doc/lispref/display.texi (Xwidgets): Document changes.

This should say "Document 'kill-xwidget'."

> +DEFUN ("kill-xwidget", Fkill_xwidget, Skill_xwidget,
> +       1, 1, 0,
> +       doc: /* Kill live xwidget XWIDGET.

One of the two "xwidget"s is redundant.  Our style in these cases is
like this:

  Kill the specified XWIDGET.

> +  if (!NILP (xw->script_callbacks))
> +    for (ptrdiff_t idx = 0; idx < ASIZE (xw->script_callbacks); idx++)

It is better to use braces around the for-loop, although strictly
speaking they aren't needed here.  But the code reads easier with
them.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]