[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds
From: |
Stefan Monnier |
Subject: |
Re: emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds of events |
Date: |
Sat, 20 Nov 2021 08:20:53 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
> Fix `browse-url-interactive-arg' for certain kinds of events
>
> * lisp/net/browse-url.el (browse-url-interactive-arg): Don't
> call `mouse-set-point' unless event is actually a mouse event.
> ---
> lisp/net/browse-url.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
> index 3af37e4..50d11b4 100644
> --- a/lisp/net/browse-url.el
> +++ b/lisp/net/browse-url.el
> @@ -730,7 +730,8 @@ position clicked before acting.
> This function returns a list (URL NEW-WINDOW-FLAG)
> for use in `interactive'."
> (let ((event (elt (this-command-keys) 0)))
> - (and (listp event) (mouse-set-point event)))
> + (when (mouse-event-p event)
> + (mouse-set-point event)))
> (list (read-string prompt (or (and transient-mark-mode mark-active
> ;; rfc2396 Appendix E.
> (replace-regexp-in-string
Shouldn't this be fixed in `mouse-set-point` (or even `event-end` and
`event-start`) instead, and then we should remove the `listp` test since
`mouse-set-point` nowadays should work with any kind of event.
Stefan
- Re: emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds of events,
Stefan Monnier <=