Re: Merging the pgtk branch

[Po Lu]

Po Lu <luangruo@yahoo.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Thanks, I guess it is now up to the people who use(d) this branch: if
>> they say it's in good shape, we are ready to land it on master.
>
> That's great news!

The child frame feature on that branch is totally broken.

Evaluting the following code is enough to make it emit tens of GLib
warning messages (the product of use-after-frees) and eventually crash:

  (make-frame `((parent-frame . ,(selected-frame))))

Most of the code in gtkutil and pgtkterm is also unprepared to deal with
frames that don't have an outer widget, which is the case with pgtk
child frames.  That code will have to be carefully reviewed and
reworked.

Needless to say, unparenting child frames or reparenting child frames to
another frame is even more hopeless.

I plan to rework that feature.  Before that, please do not merge the
pgtk branch.