emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-key


From: Eli Zaretskii
Subject: Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap.
Date: Fri, 10 Dec 2021 17:00:11 +0200

> +** Convert defvar foo-mode-map to defvar-keymap
> +Verify the conversion by comparing the value of the keymap before
> +converting it and after (you can see the value in 'C-h v').

Really?  What are the benefits of doing such a conversion?  I see only
a lot of code churn and a risk of breaking things that are perfectly
fine as they are.

And that goes for many of the changes in this direction you made
lately, btw: why are we making all those changes for purely stylistic
reasons?  It was always our policy not to do that except when fixing
real bugs in the same area.

I'd prefer that the energy and the time you have to work on Emacs
would be invested to make more important changes: fixing bugs, adding
new features, etc.  We don't have enough resources to expend them on
changes like these ones.

TIA



reply via email to

[Prev in Thread] Current Thread [Next in Thread]