[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad
From: |
Corwin Brust |
Subject: |
Re: master ad5cf84fa7: Add `auth-info-password' and use it instead of ad hoc code |
Date: |
Sat, 8 Jan 2022 11:40:29 -0600 |
Hi Michael,
On Sat, Jan 8, 2022 at 2:54 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Sam Steingold <sds@gnu.org> writes:
>
> Tramp ought to use a different implementation:
>
> --8<---------------cut here---------------start------------->8---
> > - (while (functionp auth-passwd)
> > - (setq auth-passwd (funcall auth-passwd)))
> --8<---------------cut here---------------end--------------->8---
>
> I have no reference for the problem which has triggered this, all I've
> found is this ChangeLog entry:
>
> --8<---------------cut here---------------start------------->8---
> 2018-05-02 Michael Albinus <michael.albinus@gmx.de>
>
> * tramp.el: ...
> (tramp-read-passwd): auth-source could return cascaded functions.
> --8<---------------cut here---------------end--------------->8---
>
> Perhaps it is better to use the loop as well in auth-info-password?
Looking at this patch last night I had the same idea -- I don't see
any reason *not* to allow cascaded functions in all cases while not
allowing this for Tramp would actually be breaking.
FWIW, I too wondered if there was any bug related to this or if this
was simply pushed as an ad-hoc improvement across core/bundled
packages.
Warm regards,
Corwin