[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Findirect_function
From: |
Manuel Giraud |
Subject: |
Re: [PATCH] Findirect_function |
Date: |
Fri, 14 Jan 2022 17:48:31 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> /* Optimize for no indirection. */
>> - if (SYMBOLP (fun) && !NILP (fun)
>> - && (fun = XSYMBOL (fun)->u.s.function, SYMBOLP (fun)))
>> - {
>> - fun = indirect_function (fun);
>> - if (NILP (fun))
>> - /* Let funcall get the error. */
>> - fun = args[0];
>> - }
>> + fun = Findirect_function(fun, Qt);
>> + if (NILP (fun))
>> + /* Let funcall get the error. */
>> + fun = args[0];
>
> This should remove the corresponding comment.
You mean the /* Optimize… */ comment, right?
> And I think I'd only be willing to make such a change if it comes with
> some benchmarking showing that this optimization does not actually make
> a difference.
Do you happen to have some hints on how to do benchmarking in emacs? 😅
--
Manuel Giraud
- [PATCH] Findirect_function, Manuel Giraud, 2022/01/14
- Re: [PATCH] Findirect_function, Mattias Engdegård, 2022/01/14
- Re: [PATCH] Findirect_function, Eli Zaretskii, 2022/01/14
- Re: [PATCH] Findirect_function, Andreas Schwab, 2022/01/14
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/14
- Re: [PATCH] Findirect_function,
Manuel Giraud <=
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/14
- Re: [PATCH] Findirect_function, Manuel Giraud, 2022/01/17
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/17
- Re: [PATCH] Findirect_function, Stefan Monnier, 2022/01/17
- Re: [PATCH] Findirect_function, Po Lu, 2022/01/17