emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 99c637499e: Only apply last change to the clipboard


From: Stefan Monnier
Subject: Re: master 99c637499e: Only apply last change to the clipboard
Date: Tue, 01 Feb 2022 00:20:30 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

> @@ -173,6 +173,7 @@ decoded.  If `gui-get-selection' signals an error, return 
> nil."
>    (unless (and (memq window-system '(x haiku))
>                 ;; gui-backend-selection-p might be unreliable on other
>                 ;; window systems.
> +               (eq type 'CLIPBOARD)
>                 (gui-backend-selection-owner-p type))
>      (let ((request-type (if (memq window-system '(x pgtk))
>                              (or x-select-request-type

The comment is weird.  Is it meant to apply to the line of code *above* it?
If so, please move it since we follow the convention to put comments
*before* the code to which they apply.  Also I suspect that you meant to
say `gui-backend-selection-owner-p` rather than
`gui-backend-selection-p` in the comment, right?

BTW rather than use such tests we should probably change
`gui-backend-selection-owner-p` so it can return yes/no/dontknow.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]