emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 99c637499e: Only apply last change to the clipboard


From: Stefan Monnier
Subject: Re: master 99c637499e: Only apply last change to the clipboard
Date: Tue, 01 Feb 2022 00:35:42 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

>> The comment is weird.  Is it meant to apply to the line of code
>> *above* it?  If so, please move it since we follow the convention to
>> put comments *before* the code to which they apply.
>
> That will be fixed, thanks.
>
>> Also I suspect that you meant to say `gui-backend-selection-owner-p`
>> rather than `gui-backend-selection-p` in the comment, right?
>
> Yes, thanks.

Thanks for confirming.

>> BTW rather than use such tests we should probably change
>> `gui-backend-selection-owner-p` so it can return yes/no/dontknow.
> The problem is that I don't really know why it doesn't work on those
> ports.  I just observed them returning nonsensical values.

Even if we don't know why, it'd be cleaner to put it there than here.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]