[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] externals/elisp-benchmarks 8a8e9fa6a8: Make it usable on Emac
From: |
Stefan Monnier |
Subject: |
Re: [elpa] externals/elisp-benchmarks 8a8e9fa6a8: Make it usable on Emacs-27 |
Date: |
Thu, 10 Feb 2022 08:55:39 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
>> (let ((tests (let ((names '()))
>> (mapatoms (lambda (s)
>> (let ((name (symbol-name s)))
>> - (when (string-match
>> - "\\`elb-\\(.*\\)-entry\\'" name)
>> + (when (and (fboundp s)
>> + (string-match
>> + "\\`elb-\\(.*\\)-entry\\'" name))
>> (push (match-string 1 name) names)))))
>
> Ah okay I see now. Your previous changeset is fixed here changing the
> semantic of `elisp-benchmarks-run'.
Not that the only change here is the use of `fboundp` to make sure we
don't try to run `elb-foo-entry` just because there's a symbol by that
name in the obarray.
> This change (as others) has really nothing to do with "Make it usable on
> Emacs-27".
It does: in Emacs-27, the function `elb-pack-unpack-entry` ends up not
being defined, but it somehow does end up interned in `obarray`.
Stefan