emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lis


From: Eli Zaretskii
Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp
Date: Sun, 13 Feb 2022 14:19:10 +0200

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  emacs-devel@gnu.org
> Date: Sun, 13 Feb 2022 09:28:53 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > AFAIU, it attempts to show more significant digits when the value is
> > near a round power.
> 
> Looks like it was introduced by this:
> 
> commit 04f33f1ed9cdfed6a3e44a55d333cd19d58424ca
> Author:     Eli Zaretskii <eliz@gnu.org>
> AuthorDate: Sat Apr 9 09:59:26 2011 +0300
> 
>     Produce more accurate results from file-size-human-readable.
>     
>      lisp/files.el (file-size-human-readable): Produce one digit after
>      decimal, like "ls -lh" does.
> 
> But ls -lh does not use a digit after the decimal in this case.  At
> least now -- perhaps it did in 2011?  On Debian/bookworm:
> 
> larsi@giant:~/src/emacs/trunk$ ls -lh /tmp/bytes
> -rw-r--r-- 1 larsi larsi 1006K Feb 12 08:04 /tmp/bytes

Neither does ls-lisp:

  -rw-rw-rw-  1 Zaretskii  1006k 02-13 14:07 test-of-ls.size.txt

I don't think we reproduce the original bug report.  It said:

  -rw-r--r--  1 salutis 1016.1k 12-23 17:05 default

and I don't think we know how many bytes that file actually had.
Rudolf, can you tell us how large was that file in bytes?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]