[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master c3e064013e: (loadhist_initialize): Minor refactoring
From: |
Lars Ingebrigtsen |
Subject: |
Re: master c3e064013e: (loadhist_initialize): Minor refactoring |
Date: |
Sun, 20 Feb 2022 17:25:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> (loadhist_initialize): Minor refactoring
>
> Consolidate a bit of code.
>
> * src/lread.c (loadhist_initialize): New function.
> (Fload, readevalloop): Use it.
It seems like this makes a number of tests fail:
bin/bash: line 3: 3621759 Aborted HOME=/nonexistent LANG=C
EMACS_TEST_DIRECTORY=/home/larsi/src/emacs/trunk/test "../src/emacs"
--module-assertions --no-init-file --no-site-file --no-site-lisp -L ":." -l ert
-l lisp/emacs-lisp/gv-tests --batch --eval '(ert-run-tests-batch-and-exit
(quote (not (or (tag :expensive-test) (tag :unstable)))))' >
lisp/emacs-lisp/gv-tests.log 2>&1
Running 8 tests (2022-02-20 17:21:24+0100, selector ‘(not (or (tag
:expensive-test) (tag :unstable)))’)
lread.c:1175: Emacs fatal error: assertion failed: STRINGP (filename)
make[3]: *** [Makefile:184: lisp/emacs-lisp/gv-tests.log] Error 134
make[3]: Leaving directory '/home/larsi/src/emacs/trunk/test'
make[2]: [Makefile:341: check-doit] Error 2 (ignored)
SUMMARY OF TEST RESULTS
-----------------------
Files examined: 395
Ran 5965 tests, 158 failed to run, 5835 results as expected, 0 unexpected, 130
skipped
5 files did not finish:
src/lread-tests.log
lisp/simple-tests.log
lisp/emacs-lisp/gv-tests.log
lisp/emacs-lisp/edebug-tests.log
lisp/emacs-lisp/cl-generic-tests.log
This is with --with-native-compilation, if that makes a difference.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: master c3e064013e: (loadhist_initialize): Minor refactoring,
Lars Ingebrigtsen <=