emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix placement of toggle and radio button in Lucid menu.


From: Eli Zaretskii
Subject: Re: [PATCH] Fix placement of toggle and radio button in Lucid menu.
Date: Fri, 25 Feb 2022 15:05:18 +0200

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: luangruo@yahoo.com,  emacs-devel@gnu.org
> Date: Fri, 25 Feb 2022 13:52:25 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Can we please take a step back and try to understand the issue better?
> > I asked a question in this thread; can we have an answer to that
> > question?
> 
> I can answer for font's height and ascent on an example but I don't know
> how to have the "actual metrics of the upper-case characters shown"

They are available in gui_produce_glyphs (look for "pcm").

> > Basically, I don't understand why the original code doesn't appear to
> > do its job as intended.  If you do understand, please post a detailed
> > explanation of the reason.
> 
> Ok so I found the button to be a bit to high regarding to their
> labels. My second patch place the base of the button *on* the baseline
> (ie. a bit lower than the actual code)
> 
> But, in the mean time (with help of Po Lu's last mail), I understood
> that the code is intended to have the button in the middle of the
> baseline and the top of the font (am I correct?).
> 
> Still it seems a bit too high. As I suggested in another message, it
> might be the size of the button that is too big here.

So is this just an aesthetic issue?  If so, perhaps adding a variable
exposed to Lisp could be enough: then users who, like you, dislike the
default display, can control the offset.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]