Re: [PATCH] Fix bookmark-bmenu-list sorting.

[Manuel Giraud]

Karl Fogel <kfogel@red-bean.com> writes:

> Manuel, could you please give me a more verbose reproduction recipe
> for that last paragraph above?  Maybe even include a screenshot?
>
> I've attached an updated patch here (please use this version), and
> when I test it, I don't see anything that says "sorted by bookmark
> name".  I don't know what the tabulated-list bar you're referring to
> is, but I don't see anything that would obviously be it.
>
> (I have tried things like turning `menu-bar-mode' on and off. I've
> also tried looking in the code of "lisp/emacs-lisp/tabulated-list.el",
> but I don't see any place where a message "sorted by bookmark name"
> would be set up.)

Hi Karl,

I'm sorry I was not clear at all. The «sorted by bookmark name» I was
refering to is the information about the "Bookmark" column entry being
bold and with a down-triangle next to it (ie. what you are describing
later in your message).

> Now, there is another related UI issue:
>
> In the tabulated-list header line at the top of the buffer, we have
> the expected three columns: "Bookmark", "Type", and "File". The first
> column, "Bookmark", has a down-triangle / up-triangle toggle for
> switching between descending and ascending sort by bookmark name.  But
> if `bookmark-sort-flag' is nil, then when the buffer is regenerated
> the bookmarks will be listed in creation-date order -- and the
> triangular toggle will just keep whichever value the triangle had
> already.

So yes that was what I was talking about (only better described 😅).

> Maybe the right fix for that is for the buffer to somehow indicate
> *which* property the bookmarks are sorted by -- name or creation-date
> -- and make sure that the triangle always reflects the sorting
> direction of whichever thing is currently being sorted on.  However,
> before I go down that road, I'd like to fully understand your initial
> "one minor thing" bug report above first.

Or maybe you can «reset the state» of the tabulated-list (as it is on
first bookmark-bmenu-list call)? But I don't really know how
tabulated-list works.

Best regards,
-- 
Manuel Giraud