[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8b7aaf3e56: Speed up GIF animations
From: |
Lars Ingebrigtsen |
Subject: |
Re: master 8b7aaf3e56: Speed up GIF animations |
Date: |
Mon, 11 Apr 2022 15:10:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Po Lu <luangruo@yahoo.com> writes:
>> + int cache_image_size = width * height * ximg->bits_per_pixel / 8;
>
> Emacs_Pix_Container is an opaque type that can be typedefed to a variety
> of things on different platforms.
>
> You cannot directly refer to bits_per_pixel, which only exists on X.
> This will probably break if bits_per_pixel is not a multiple of 8 as
> well. It can be any random value on X Windows, and might not even exist
> if the image format is not ZPixmap.
Right.
> What is the temp field for? Is it for storing bitmap data? If so, it
> should just be a bitmap set using the PUT_PIXEL macro.
I want to copy the bitmap that we've already computed in an efficient
way. PUT_PIXEL would be way too slow. Any ideas?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no