[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 5141234acf: Refactor the webp cache code to allow usage by gi
From: |
Eli Zaretskii |
Subject: |
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too |
Date: |
Mon, 11 Apr 2022 16:29:33 +0300 |
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org, larsi@gnus.org
> Date: Mon, 11 Apr 2022 21:25:07 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Po Lu <luangruo@yahoo.com>
> >> Cc: Lars Ingebrigtsen <larsi@gnus.org>
> >> Date: Mon, 11 Apr 2022 20:15:12 +0800
> >>
> >> > + cache->spec = spec;
> >>
> >> I think this should be marked, since I don't see what protects the spec
> >> from garbage collection otherwise.
> >
> > 'spec' here is img->spec, right?
>
> Right, but the animation cache can persist after img is gone, right?
It can? Then how does this work:
struct anim_cache* cache = anim_get_animation_cache (img->spec);
We pass img->spec to look it up in the cache, don't we? And we use EQ
to look it up, right?
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, (continued)
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Stefan Monnier, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Eli Zaretskii, 2022/04/11
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11