emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix eudc-get-attribute-list: please review


From: Thomas Fitzsimmons
Subject: Re: Fix eudc-get-attribute-list: please review
Date: Wed, 13 Apr 2022 22:02:08 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Hi Filipp,

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Here's the patch which fixes several bugs preventing
> eudc-get-attribute-list from working, please review.
>
> TIA,
> Filipp
>
>
> commit 17c59e12adca5386ffe7d107dc6e3fa2dcf8b8d6
> Author: Filipp Gunbin <fgunbin@fastmail.fm>
> Date:   Wed Apr 13 23:10:35 2022 +0300
>
>     Fix eudc-get-attribute-list
>     
>     * lisp/net/eudc-vars.el (eudc-ldap-no-wildcard-attributes): New
>     defcustom.
>     * doc/misc/eudc.texi (LDAP Configuration): Mention it.
>     * lisp/net/eudcb-ldap.el (eudc-ldap-format-query-as-rfc1558): Use it.
>     (eudc-ldap-get-field-list): Set scope and sizelimit, instead of
>     overriding the whole ldap-host-parameters-alist.
>     * lisp/net/ldap.el (ldap-search-internal): Allow "size limit exceeded"
>     exit code.  Allow empty attribute values.

Looks good, and works for me.  Please go ahead and push this to the
master branch.  One question: what does the addition of the question
mark to the regexp fix?

Thanks,
Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]