Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop

[Stefan Monnier]

Po Lu [2022-04-17 11:55:23] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> This is pretty ugly.
>> Why is it that it "does nothing"?  Any hope we can move this restoration
>> of `pending_signals` closer to the code that "does nothing"?
> No, because we don't know the prior value of `pending_signals' in that
> code.

How bout the first question?

Also, I'm pretty sure the real answer isn't "no" because we can surely
move it to the place where `pending_signals` is changed and that is closer
at least in terms of "dynamic distance".

> In general, the interaction between async input and the event loop run
> during a drag is pretty confusing, especially on GTK+.

And we should make this complexity much more explicit in the code rather
than add magic hacks linked via occasional comments.


        Stefan