emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Handle case where `beg` and `end` are strings instead of mar


From: James N . V . Cash
Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers
Date: Thu, 28 Apr 2022 21:10:32 -0400

"James N. V. Cash" <james.nvc@gmail.com> writes:

> With the changes to pass affixes to the completion functions, the
> begin and end points passed to the completion function are now
> sometimes strings instead of numbers or markers. This handles that
> case by searching for said prefix and suffix.
>
> Without this, completion functions that call `completion--replace` error
> out -- for example, completing tags in org-mode.

Hm, while my patch does fix the error I was seeing, it makes completing
multiple items with completing-read-multiple not properly insert
subsequent completions.

I also note that I only saw the aberrant behaviour while using functions
that used CRM, so perhaps there's a more underlying cause and/or better
place to fix this.

James



reply via email to

[Prev in Thread] Current Thread [Next in Thread]