emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f2d2fe6fc8: server-execute: Initialize the *scratch* buffer


From: Sean Whitton
Subject: Re: master f2d2fe6fc8: server-execute: Initialize the *scratch* buffer
Date: Wed, 04 May 2022 07:23:32 -0700
User-agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu)

Hello,

On Wed 04 May 2022 at 08:47am -04, Stefan Monnier wrote:

>>> Could we put that code in a function so we don't need to duplicate it
>>> (and sync it)?
>> There's a similar thing in a lot of different places in C, too.
>> My own inclination is that it's simple, and in fact slightly different
>> in different places, so not worth factoring out, but YMMV.
>
> If you could factor out the commonality (and remove the gratuitous
> differences along the way), I'd be grateful.
> In my experience, it's always worth it in the long run (and it's
> generally an opportunity to improve the code, because once it only
> exists at a single place, it's much easier to add functionality and
> customizability to it).

In order to factor it out of the C as well I need to define it in C with
the DEFUN macro, right?  Otherwise each C callsite would have to use
Ffuncall, which doesn't seem right.

-- 
Sean Whitton



reply via email to

[Prev in Thread] Current Thread [Next in Thread]