|
| From: | Paul Eggert |
| Subject: | Re: master eb37e4814e 3/3: Fix unlikely null pointer dereference |
| Date: | Sat, 28 May 2022 10:14:43 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 5/27/22 17:46, Po Lu wrote:
How can name be NULL if had_errors_p is false? x_get_atom_name always returns something if need_sync is false, and XGetAtomName always returns a string unless an error occured.
Oh, you're right - I hadn't noticed that. So my recent patch didn't fix any runtime bugs, though it did pacify GCC and I hope made the confusing code a bit easier to follow for humans too.
I see you made further improvements in the area; thanks.
| [Prev in Thread] | Current Thread | [Next in Thread] |