emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function


From: Lars Ingebrigtsen
Subject: Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function
Date: Sat, 11 Jun 2022 12:57:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> But besides the `test-completion` part of the completion table, this new
> feature also overlaps with the `predicate` argument.  I think it would
> be good to write down somewhere how those three compare.

The PREDICATE argument is under-documented, yes -- it's just supposed to
be a filter on COLLECTION, isn't it?

> I see that the `minibuffer-completion-confirm` function completely
> replaces the usual handling of require-match (i.e. the attempt to fix
> the case and the prompting for confirmation).

(You probably noticed it, but in case not -- I didn't change that code,
I just changed the indentation.)

> Maybe this should be better documented, and also AFAICT currently
> a `minibuffer-completion-confirm` function cannot reliably reproduce this
> behavior by hand because it doesn't have access to `beg` and `end`.
> I think we should make this "default behavior" more easily accessible
> (e.g. put it into its own function and document it as something that can
> be called from `minibuffer-completion-confirm`?).

I'm pretty sure I don't understand the subtleties here, but er sure?  🧐

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]