Re: Autoload is being read inside documentation

[Basil L. Contovounesios]

Lars Ingebrigtsen [2022-06-04 18:46 +0200] wrote:

> Daniel Fleischer <danflscr@gmail.com> writes:
>
>> Hi, I've noticed a possible bug where an ;;;###autoload directive is
>> being read inside a documentation string of some `defvar` which didn't
>> happen before.
>
> There shouldn't be any such doc string in the Emacs tree -- did you find
> this problem with an external package?
>
> I've now made the scanner check whether it's inside a string (when
> scanning outside of the Emacs build).

Thanks, but git-bisect says this change had other fallout with package
autoloads:

e74652386d62a5a6142bf6332e0e4b4aa48c7088 is the first bad commit
commit e74652386d62a5a6142bf6332e0e4b4aa48c7088
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date:   Sat Jun 4 18:41:10 2022 +0200
    Make loaddefs-generate--parse-file more robust

    * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file):
    Ensure that we don't have an autoload cookie on the first column
    inside a string.

Here's the recipe:

$ cd "$(mktemp -d)"
$ export HOME="$PWD" XDG_CONFIG_HOME="$PWD/.config"
$ emacs -Q
M-x package-install RET auctex RET
C-x C-c
$ emacs -Q -f toggle-debug-on-error -f package-initialize
C-x C-f foo.tex RET

Here's the backtrace:

backtrace.txt
Description: Text document

It looks like a subset of AUCTeX's autoloads are no longer included in
auctex-autoloads.el:

auctex-autoloads.diff
Description: Text Data

-- 
Basil

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
 of 2022-06-14 built on tia
Repository revision: e74652386d62a5a6142bf6332e0e4b4aa48c7088
Repository branch: HEAD
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --prefix=/home/blc/.local --with-x-toolkit=no --without-x'

Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND SQLITE3 THREADS XIM ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Debugger

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message yank-media rmc puny dired dnd
dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config
gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils help-fns radix-tree cl-print debug
backtrace help-mode find-func tex-mode compile text-property-search
shell pcomplete comint ansi-color ring latexenc finder-inf info tool-bar
auctex-autoloads tex-site package browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars seq cl-loaddefs
cl-lib cus-start cus-load term/xterm xterm gv subr-x byte-opt bytecomp
byte-compile cconv regexp-opt iso-transl tooltip eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list
replace newcomment text-mode lisp-mode prog-mode register page tab-bar
menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
multi-tty make-network-process emacs)

Memory information:
((conses 16 109799 6599)
 (symbols 48 10658 0)
 (strings 32 35218 2075)
 (string-bytes 1 1023582)
 (vectors 16 16588)
 (vector-slots 8 191428 5927)
 (floats 8 41 32)
 (intervals 56 675 0)
 (buffers 992 12))