[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] externals/denote 5ab937f1da: Require 'subr-x' at compile time
From: |
Philip Kaludercic |
Subject: |
Re: [elpa] externals/denote 5ab937f1da: Require 'subr-x' at compile time |
Date: |
Sun, 24 Jul 2022 16:18:29 +0000 |
ELPA Syncer <elpasync@gnu.org> writes:
> branch: externals/denote
> commit 5ab937f1da1437f777fa7beb368521f628245810
> Author: Protesilaos Stavrou <info@protesilaos.com>
> Commit: Protesilaos Stavrou <info@protesilaos.com>
>
> Require 'subr-x' at compile time
>
> This is to be sure that Emacs 28 evaluates 'when-let*'. Otherwise we
> will end up with errors such as the one reported by hpgisler in issue 62
> on the GitHub mirror: <https://github.com/protesilaos/denote/issues/62>.
> ---
> denote.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/denote.el b/denote.el
> index 2152c695a5..00e264b6a8 100644
> --- a/denote.el
> +++ b/denote.el
> @@ -96,7 +96,9 @@
> ;;; Code:
>
> (require 'seq)
> -(eval-when-compile (require 'cl-lib))
> +(eval-when-compile
> + (require 'cl-lib)
> + (require 'subr-x))
Indirectly related: Why is cl-lib evaluated only at compile time? From
what I see the only functions you use are cl-find-if and cl-some,
neither of which have any effect at compile time, both of which you
declare. As you already require seq, I'd either use (seq-find and
seq-some should do the job) that or require cl-lib "regularly".
> (defgroup denote ()
> "Simple notes with an efficient file-naming scheme."
- Re: [elpa] externals/denote 5ab937f1da: Require 'subr-x' at compile time,
Philip Kaludercic <=