[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 0da97d6: * src/keyboard.c (timer_check_2): Replace redundant
From: |
Eli Zaretskii |
Subject: |
Re: master 0da97d6: * src/keyboard.c (timer_check_2): Replace redundant test with assertion |
Date: |
Fri, 05 Aug 2022 21:20:09 +0300 |
IMNSHO, this change is dangerous: it replaces run-time conditions with
assertions, but IME most if not all of the active developers and
people who track the master branch don't compile with --enable-checking,
or don't run the trunk build on a regular basis. Which means these
assertions, if they happen, will not be seen nor reported.
So basically you removed a safety net without any replacement.
I suggest to revert this change. It gains us nothing of importance.
- Re: master 0da97d6: * src/keyboard.c (timer_check_2): Replace redundant test with assertion,
Eli Zaretskii <=