emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 7c793c55cf 2/2: Improve 'ns-read-file-name' docstring


From: Po Lu
Subject: Re: master 7c793c55cf 2/2: Improve 'ns-read-file-name' docstring
Date: Sat, 20 Aug 2022 10:03:03 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)

Robert Pluim <rpluim@gmail.com> writes:

>     Improve 'ns-read-file-name' docstring
>     
>     * src/nsfns.m (Fns_read_file_name): Use '-' instead of '_' when naming
>     args.
> ---
>  src/nsfns.m | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/nsfns.m b/src/nsfns.m
> index 1d3dcd3124..2699cf37a5 100644
> --- a/src/nsfns.m
> +++ b/src/nsfns.m
> @@ -1727,7 +1727,7 @@ Optional arg DIR, if non-nil, supplies a default 
> directory.
>  Optional arg MUSTMATCH, if non-nil, means the returned file or
>  directory must exist.
>  Optional arg INIT, if non-nil, provides a default file name to use.
> -Optional arg DIR_ONLY_P, if non-nil, means choose only directories.  */)
> +Optional arg DIR-ONLY-P, if non-nil, means choose only directories.  */)
>    (Lisp_Object prompt, Lisp_Object dir, Lisp_Object mustmatch,
>     Lisp_Object init, Lisp_Object dir_only_p)
>  {

I guess in a few days I will delete this function and replace it with an
implementation of x-file-dialog in C, like the rest of the ports do.  I
think ns-read-file-name predates x-file-dialog, and the Lisp wrapper was
then halfheartedly placed on top shortly before the NS port was merged.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]