emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a pa


From: Dmitry Gutov
Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349)
Date: Wed, 31 Aug 2022 19:41:47 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 31.08.2022 19:21, Dmitry Gutov wrote:
On 31.08.2022 19:06, Juri Linkov wrote:
But a loop is necessary because the diff can have more than one hunk, isn't
it?
A loop is necessary indeed.  The problem is that I tried it with Bzr,
but it has such a bug that `bzr diff` adds an extra line at the end,
so it's not (eobp) after the last diff hunk.  After removing the
final newline in the*vc-diff*  buffer the loop can be finished.

Hmm, so how do we apply the full diff in a backend-agnostic fashion?

Should we delegate to 'patch', then? And require it to be installed.

I suppose we could check whether every diff-apply-hunk advances point, though.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]