|
From: | Jim Porter |
Subject: | Re: master 50020d026c: Untabify rcirc.el |
Date: | Wed, 7 Sep 2022 09:42:54 -0700 |
On 9/7/2022 4:23 AM, Po Lu wrote:
Philip Kaludercic <philipk@posteo.net> writes:branch: master commit 50020d026cda1fdd70d8a08e08185dbb7183646a Author: Philip Kaludercic <philipk@posteo.net> Commit: Philip Kaludercic <philipk@posteo.net> Untabify rcirc.el(There's nothing wrong with tabs, not in Lisp code, not elsewhere. But that's besides the point.) Please don't make whitespace changes like this. It makes vc-annotate nonfunctional and is very much unnecessary.
Perhaps we should set 'blame.ignoreRevsFile'[1] in the Emacs repo's Git config (and then add this commit SHA to that file)? That should make vc-annotate - and anything else that uses "git blame" - ignore this commit, along with any other mechanical commits that shouldn't count for the purposes of blame.
I believe this was introduced in Git 2.23 (from Aug 2019), so most people with relatively-recent Git installs should be able to use this. I'm not sure how robust this feature is (i.e. can it properly ignore complex changes?), but for changing tabs to spaces, that should be pretty trivial for Git to figure out.
[1] https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt
[Prev in Thread] | Current Thread | [Next in Thread] |