Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection

[Philip Kaludercic]

ELPA Syncer <elpasync@gnu.org> writes:

> branch: externals/ef-themes
> commit 71fb847ecaed028f2c7f4b798d311b8e59df3db1
> Author: Protesilaos Stavrou <info@protesilaos.com>
> Commit: Protesilaos Stavrou <info@protesilaos.com>
>
>     Add FIXME about simplifying ef-themes-collection
> ---
>  ef-themes.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/ef-themes.el b/ef-themes.el
> index d082d7dc6e..0a6b04e59a 100644
> --- a/ef-themes.el
> +++ b/ef-themes.el
> @@ -48,6 +48,9 @@
>  
>  ;;; User options
>  
> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
> +;; This duplication seems unnecessary.
>  (defconst ef-themes-collection
>    '(ef-autumn
>      ef-dark

Is there any reason you couldn't just replace the definition with

   (seq-union ef-themes-light-themes ef-themes-dark-themes)

?