emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 59df0a7bd9: Add a VC command to prepare patches


From: Philip Kaludercic
Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches
Date: Sun, 09 Oct 2022 12:30:40 +0000

Sean Whitton <spwhitton@spwhitton.name> writes:

> Hello,
>
> On Sat 08 Oct 2022 at 05:29PM GMT, Philip Kaludercic wrote:
>
>> Yes, but I would wait a bit to avoid the same issues as we had when
>> `diff-add-log-use-relative-names' was set.  Anyone who had pulled the
>> new commits with the change but hadn't rebuilt Emacs to know that these
>> are safe values was prompted the "are you sure these variables are safe"
>> queries.  If we wait for a week or two then I would guess that most
>> people following development will have pulled and rebuilt at least once
>> by then.
>
> Cool.  Perhaps the docstring for vc-prepare-patches-separately should
> also mention that it can be set locally, then?

I don't think it is necessary, that information is automatically
inserted into the help buffer:

        vc-prepare-patches-separately is a variable defined in ‘vc.el’.

        Its value is t

        Non-nil means that ‘vc-prepare-patch’ creates a single message.
        A single message is created by attaching all patches to the body
        of a single message.  If nil, each patch will be sent out in a
        separate message, which will be prepared sequentially.

-->       This variable is safe as a file local variable if its value
          satisfies the predicate ‘booleanp’.
          This variable was introduced, or its default value was changed, in
          version 29.1 of Emacs.
          You can customize this variable.

        [back]

> (Btw, just filed a feature request, but forgot to X-debbugs-cc you.)

bug#58383 I assume?

> Thanks for this cool new feature.

I am glad it is of use.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]