emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Matching regex case-sensitively in C strings?


From: Eli Zaretskii
Subject: Re: Matching regex case-sensitively in C strings?
Date: Tue, 08 Nov 2022 21:37:49 +0200

> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 8 Nov 2022 11:31:35 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>,
>  emacs-devel <emacs-devel@gnu.org>
> 
> +  Lisp_Object translate_table = ignore_case ? Vascii_canon_table : Qnil;

Please don't call this "translate_table", as it isn't.  The
documentation elsewhere calls this "canonicalize_table" or just
"canonicalize".

>  fast_c_string_match_ignore_case (Lisp_Object regexp,
>                                const char *string, ptrdiff_t len)
>  {
> +  return fast_c_string_match (regexp, string, len, true);
> +}

I'm bothered that this function, which is supposed to be fast, will
now be slower due to an extra function call.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]