[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused captur
From: |
Po Lu |
Subject: |
Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group. |
Date: |
Wed, 09 Nov 2022 20:19:57 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård <mattiase@acm.org> writes:
> branch: master
> commit 8dc36cc53b7c2b66ca06ca4db84209bc492ea665
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
> * src/lread.c (syms_of_lread): Drop unused capture group.
> ---
> src/lread.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lread.c b/src/lread.c
> index 957bc6895e..c28324dc35 100644
> --- a/src/lread.c
> +++ b/src/lread.c
> @@ -5620,7 +5620,8 @@ from the file, and matches them against this regular
> expression.
> When the regular expression matches, the file is considered to be safe
> to load. */);
> Vbytecomp_version_regexp
> - = build_pure_c_string ("^;;;.\\(in Emacs version\\|bytecomp version
> FSF\\)");
> + = build_pure_c_string
> + ("^;;;.\\(?:in Emacs version\\|bytecomp version FSF\\)");
Isn't it not our style to put the only line of parameter to a function
call on a new line? Here, I would split the string in two, like so,
instead:
build_pure_c_string ("long string here"
" next part of string here");
- Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group.,
Po Lu <=