emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 2a7f01aa38: Fix initialization of module functions


From: Eli Zaretskii
Subject: Re: master 2a7f01aa38: Fix initialization of module functions
Date: Thu, 10 Nov 2022 20:13:15 +0200

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Thu, 10 Nov 2022 12:44:56 -0500
> 
> Eli Zaretskii [2022-11-10 17:23:52] wrote:
> 
> >> >  allocate_module_function (void)
> >> >  {
> >> >    return ALLOCATE_PSEUDOVECTOR (struct Lisp_Module_Function,
> >> > -                                interactive_form, PVEC_MODULE_FUNCTION);
> >> > +                                command_modes, PVEC_MODULE_FUNCTION);
> >> >  }
> >> >  
> >> >  #define XSET_MODULE_FUNCTION(var, ptr) \
> >> 
> >> Usually we accompany that with a comment in the struct stating "this
> >> is the last GC-tracked field" or something like that.
> >
> > There's already such a comment, a few lines above.
> 
> The comment doesn't say which one is the last tracked field.

??? That's basic C, or what am I missing?

Anyway, feel free to add whatever comment you want, you don't need to
convince me (in this case).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]