emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter


From: Theodor Thornhill
Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use
Date: Tue, 15 Nov 2022 11:25:18 +0100

Randy Taylor <dev@rjt.dev> writes:

> Looks like my bug finally got created (Bug#59268) so we can continue the 
> discussion there.
>

Thumbs up.

> Will reply to what's been said so far below.
>
>
> On Monday, November 14th, 2022 at 14:20, Theodor Thornhill 
> <theo@thornhill.no> wrote:
>> 
>> Are you sure we cover most of the stuff that was covered in the old
>> style? I see it is different visually, but that's likely the new faces
>> are without any color, right?
>
> I think so, at least I don't notice anything wrong (the old style was 
> actually missing some things).
> Indeed, most of the new faces are without any colour. Property and 
> escape-sequence are the only ones
> that have any, and they inherit.
>
> Do you have any specific examples?
>

Nope, I think it's fine.  Just wanted to ask :-)

>> 
>> I think you should add similar changes to all the new modes:
>> 
>> - ts-mode
>> - json-ts-mode
>> - css-ts-mode
>> - java-ts-mode
>> - js-mode
>> 
>> If you have time and energy, of course :-)
>>
>
> I plan to. Hopefully this week and weekend.

-- 
Theo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]