[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify pars
From: |
Po Lu |
Subject: |
Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes |
Date: |
Tue, 15 Nov 2022 19:54:43 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Yuan Fu <casouri@gmail.com> writes:
> +static Lisp_Object
> +treesit_make_ranges (const TSRange *, uint32_t, struct buffer *);
This should be:
static Lisp_Object treesit_make_ranges (const TSRange *, uint32_t,
struct buffer *);
> + Lisp_Object lisp_ranges = treesit_make_ranges(ranges, len, buf);
There is a missing space between "treesit_make_ranges" and its
parameters.
> + FOR_EACH_TAIL (functions)
> + safe_call2(XCAR (functions), lisp_ranges, parser);
Here too, between safe_call2 and the parameters.
> + treesit_call_after_change_functions(tree, new_tree, parser);
And here.
> +DEFUN ("treesit-parser-notifiers",
> + Ftreesit_parser_notifiers,
> + Streesit_parser_notifiers,
> +
> +DEFUN ("treesit-parser-add-notifier",
> + Ftreesit_parser_add_notifier,
> + Streesit_parser_add_notifier,
> +
> +DEFUN ("treesit-parser-remove-notifier",
> + Ftreesit_parser_remove_notifier,
> + Streesit_parser_remove_notifier,
Can't you put all of these on one line?
- Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes,
Po Lu <=