emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 409f0430b6: Fix click position to menu bar entry with no-tool


From: Po Lu
Subject: Re: master 409f0430b6: Fix click position to menu bar entry with no-toolkit
Date: Sat, 19 Nov 2022 12:36:15 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Sean Whitton <spwhitton@spwhitton.name> writes:

> Hello,
>
> On Fri 18 Nov 2022 at 07:24PM -05, Po Lu via Mailing list for Emacs changes 
> wrote:
>
>> branch: master
>> commit 409f0430b6a0c138836e5067141bf6b2a7beb6b3
>> Author: Manuel Giraud <manuel@ledu-giraud.fr>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     Fix click position to menu bar entry with no-toolkit
>>
>>     * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to
>>     compute correct menu bar position should the menu face change.
>>     * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore.
>>     * src/dispextern.h: Export x_y_to_hpos_vpos.
>
> Looks like this breaks the build:
>
>     keyboard.c: In function ‘make_lispy_event’:
>     keyboard.c:5980:43: error: ‘struct frame’ has no member named 
> ‘menu_bar_window’; did you mean ‘tab_bar_window’?
>      5980 |       struct window *menu_w = XWINDOW (f->menu_bar_window);
>           |                                           ^~~~~~~~~~~~~~~
>           |                                           tab_bar_window
>     keyboard.c:5986:37: error: ‘struct frame’ has no member named 
> ‘menu_bar_window’; did you mean ‘tab_bar_window’?
>      5986 |       x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), x, y, 
> &column, &row,
>           |                                     ^~~~~~~~~~~~~~~
>           |                                     tab_bar_window

I will fix that shortly, thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]