[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 350918e7be: Adjust x_display_set_last_user_time for Xlib sign
|
From: |
Po Lu |
|
Subject: |
Re: master 350918e7be: Adjust x_display_set_last_user_time for Xlib sign-extension |
|
Date: |
Tue, 22 Nov 2022 21:16:02 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 22 Nov 2022 07:58:19 -0500 (EST), Po Lu via Mailing list for
>>>>>> Emacs changes <emacs-diffs@gnu.org> said:
> Po Lu> + /* Time can be sign extended if retrieved from a client message.
> Po Lu> + Make sure it is always 32 bits, or systems with 64-bit longs
> Po Lu> + will crash after 24 days of X server uptime. (bug#59480) */
> Po Lu> + time &= X_ULONG_MAX;
> Po Lu> +
> Po Lu> #ifdef ENABLE_CHECKING
> Po Lu> eassert (time <= X_ULONG_MAX);
> Po Lu> #endif
>
> You could even remove the `eassert' now, but itʼs a minor thing.
>
> Robert
Right, I missed that.