emacs-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [NonGNU ELPA] 11 new packages!

From: Akib Azmain Turja
Subject: Re: [NonGNU ELPA] 11 new packages!
Date: Mon, 28 Nov 2022 01:22:08 +0600 
Philip Kaludercic <philipk@posteo.net> writes:

[...]

>>> +;; A little suggestion
>>> +;;;###autoload
>>> +(defun gnu-indent-defun-or-fill (arg)
>>> +  "Indent current function with GNU Indent.
>>> +If point is in a comment, call `fill-paragraph' instead.  A
>>> +prefix argument ARG is passed to `fill-paragraph'."
>>> +  (interactive "P")
>>> +  (if (nth 8 (syntax-ppss))           ;if in a comment
>>> +      (fill-paragraph arg)
>>> +    (let ((bounds (bounds-of-thing-at-point 'defun)))
>>> +      (if (consp bounds)
>>> +     (gnu-indent-region (car bounds) (cdr bounds))
>>> +   (user-error "No defun at point")))))
>>> +
>>
>> Great idea.  But would it cause problem to assign copyright if I take
>> your change?  (AFAIK you've completed paperwork, but in this case you're
>> not contributing to FSF-copyrighted code, so is this change covered by
>> your paperwork?  Right now, no, you're the copyright holder.  (According
>> to Section 2 of copyright assignment agreement sent to me.))
>
> I don't think there should be an issue, as we want to add the package to
> NonGNU ELPA.  If the package is later moved to GNU ELPA, then my CA
> should cover it.

Pushed, with you attributed as the author.

[...]

>>> @@ -48,6 +48,10 @@
>>>  ;;             "~/.guix-profile/share/doc/"
>>>  ;;             "~/.guix-profile/share/gtk-doc/html/"))
>>>
>>> +;; Do you think it makes sense to automatically detect this (if the
>>> +;; user has a ~/.guix-profile directory) and make the changes to the
>>> +;; default value?
>>> +
>>
>> Yes, it makes sense.  But I didn't find any way to detected the
>> directories, except heuristics.
>
> What would the problem be with checking the existence of these specific
> (or other well known directories)?
>
>    (append [default value]
>            (and (file-exists-p "~/.guix-profile/share/doc/"
>                 (list "~/.guix-profile/share/doc/")))
>            (and (file-exists-p "~/.guix-profile/share/gtk-doc/html/")
>                 (list "~/.guix-profile/share/gtk-doc/html/"))))
>

Done.  Does anybody know the Nix directories to add?

>>> @@ -219,6 +224,7 @@ If a single file was opened, only show that book's 
>>> table of contents."
>>>  See `devhelp-toc' for more details."
>>>    (let ((inhibit-read-only t))
>>>      (erase-buffer)
>>> +    ;; Why not prepare the document in SXML and then use `dom-print'?
>>>      (insert
>>>       "<html><head><title>Table of contents</title></head><body><ul>"
>>>       (let ((book-tocs
>>
>> Hmm, that would be a cleaner approach.  Now I need to research the
>> format of SXML.
>
> This gives a brief demonstration:
>
> (dom-print '(tag ((key . "value")) (sub-tag () "body")))
> ;; Output: <tag key="value"><sub-tag>body</sub-tag></tag>

Done.

[...]

-- 
Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5
Fediverse: akib@hostux.social
Codeberg: akib
emailselfdefense.fsf.org | "Nothing can be secure without encryption."

Attachment: signature.asc
Description: PGP signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]