Re: master 2772ebe366: Do not prune native-compiled system directories (bug#59658)

[Stefan Kangas]

Juanma Barranquero <lekktu@gmail.com> writes:

> branch: master
> commit 2772ebe3667f28cefd0d6134204ce6a3c7a8c323
> Author: Juanma Barranquero <lekktu@gmail.com>
> Commit: Juanma Barranquero <lekktu@gmail.com>
>
>     Do not prune native-compiled system directories (bug#59658)
>
>     * lisp/emacs-lisp/comp.el (native-compile-prune-cache):
>     Skip last directory in `native-comp-eln-load-path'.

It seems like this leads to a failing test:

Running 3 tests (2022-11-30 18:26:07+0100, selector ‘(not (or (tag
:expensive-test) (tag :unstable)))’)
Cache cleared
Test test-native-compile-prune-cache backtrace:
  signal(ert-test-failed (((should-not (file-directory-p c2)) :form (f
  ert-fail(((should-not (file-directory-p c2)) :form (file-directory-p
  #f(compiled-function () #<bytecode -0x8ca32608ded3464>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-native-compile-prune-cache :docu
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/comp-test
  command-line()
  normal-top-level()
Test test-native-compile-prune-cache condition:
    (ert-test-failed
     ((should-not
       (file-directory-p c2))
      :form
      (file-directory-p "/tmp/emacs-test-MHYUZK-comp/eln-cache/29.0.50-old")
      :value t))
   FAILED  1/3  test-native-compile-prune-cache (0.003363 sec) at
lisp/emacs-lisp/comp-tests.el:46
Cache cleared
   passed  2/3  test-native-compile-prune-cache/delete-only-eln (0.002607 sec)
Cache cleared
   passed  3/3
test-native-compile-prune-cache/dont-delete-in-parent-of-cache
(0.002566 sec)

Ran 3 tests, 2 results as expected, 1 unexpected (2022-11-30
18:26:07+0100, 0.132447 sec)

1 unexpected results:
   FAILED  test-native-compile-prune-cache

make[3]: *** [Makefile:174: lisp/emacs-lisp/comp-tests.log] Error 1