emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ruby-ts-mode.el -- first draft


From: Stefan Monnier
Subject: Re: ruby-ts-mode.el -- first draft
Date: Sat, 10 Dec 2022 23:25:39 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

> (defcustom ruby-ts-indent-tabs-mode nil
>   "Indentation can insert tabs in Ruby TS mode if this is non-nil."
>   :version "29.1"
>   :type 'boolean
>   :safe 'booleanp
>   :group 'ruby)

I'd discourage this practice of duplicating a standard buffer-local
variable <foo> with a <mode>-<foo> config var.

If `add-hook` is too much trouble for Emacs users, then we should devise
a generic way for the users to customize global vars like
`indent-tabs-mode` per-mode without forcing every major mode author to
do it by hand.

> (defcustom ruby-ts-mode-indent-style 'base

I think this var is defined twice in your file.  Did you byte-compile it?
I recommend `flymake-mode`.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]